【Hackathon 6th No.25】为 paddle.histogram/paddle.nn.functional.threshold 进行功能对齐与功能增强 #63044
+357
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
zhwesky2010
reviewed
Apr 1, 2024
| @@ -1745,7 +1745,7 @@ | |||
|
|
|||
| - op : histogram | |||
| inputs : | |||
| input : X | |||
| {input: X, weight: Weight} | |||
There was a problem hiding this comment.
拆成两个PR：一个修改threshold，一个修改histogram
| @@ -1336,8 +1336,9 @@ | |||
| backward : heaviside_grad | |||
|
|
|||
| - op : histogram | |||
| args : (Tensor input, int64_t bins = 100, int min = 0, int max = 0) | |||
| args : (Tensor input, Tensor weight, bool density = false, int64_t bins = 100, int min = 0, int max = 0) | |||
There was a problem hiding this comment.
这个参数为何要插到最前面去？非常的不兼容，升级API原则是尽可能不要影响以前的功能
| @@ -1745,7 +1745,7 @@ | |||
|
|
|||
| - op : histogram | |||
| inputs : | |||
| input : X | |||
| {input: X, weight: Weight} | |||
|
@AndPuQing 另外，除了Approval和Static-check之外的CI都需要通过 |
|
Sorry to inform you that 33ba331's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
@AndPuQing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description